Feat/2.2.1 #66
Merged
Feat/2.2.1 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommytrg
reviewed
Apr 22, 2024
configs.py
Outdated
Comment on lines
30
to
36
| value = network_config.get('feeds', {}).get(caption, {}).get(param, None) | ||
| if value is None: | ||
| value = config['conditions'].get(caption, {}).get(param, None) | ||
| if value is None: | ||
| value = config['conditions']['default'].get(param, None) | ||
| if value is None: | ||
| value = default |
There was a problem hiding this comment.
We can use the or operator to make this more concise and readable.
Suggested change
| value = network_config.get('feeds', {}).get(caption, {}).get(param, None) | |
| if value is None: | |
| value = config['conditions'].get(caption, {}).get(param, None) | |
| if value is None: | |
| value = config['conditions']['default'].get(param, None) | |
| if value is None: | |
| value = default | |
| value = (network_config.get('feeds', {}).get(caption, {}).get(param, None) | |
| or config['conditions'].get(caption, {}).get(param, None) | |
| or config['conditions']['default'].get(param, default)) |
price_feeds_poller.py
Outdated
| "secs": [] | ||
| }) | ||
| print(f" => ID4 : {pf_id}") | ||
| if routed == True: |
There was a problem hiding this comment.
Are we modifying the routed value? if not, this if statement seems unnecessary
price_feeds_poller.py
Outdated
Comment on lines
133
to
136
| for index in range(len(supports[0])): | ||
| caption = supports[1][index] | ||
| pf_id = supports[0][index].hex() | ||
| rad_hash = supports[2][index].hex() |
There was a problem hiding this comment.
I think we can use zip here.
Suggested change
| for index in range(len(supports[0])): | |
| caption = supports[1][index] | |
| pf_id = supports[0][index].hex() | |
| rad_hash = supports[2][index].hex() | |
| for (pf_id_bytes, caption_bytes, rad_hash_bytes) in zip(*supports): | |
| caption = caption_bytes.decode() | |
| pf_id = pf_id_bytes.hex() | |
| rad_hash = rad_hash_bytes.hex() |
Tommytrg
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.